Skip to content
This repository has been archived by the owner on Nov 19, 2019. It is now read-only.

Add combustion development dependency. #5

Merged
merged 1 commit into from Nov 25, 2012
Merged

Add combustion development dependency. #5

merged 1 commit into from Nov 25, 2012

Conversation

ltw
Copy link

@ltw ltw commented Nov 18, 2012

Specs weren't running without combustion declared as a development dependency.

@jasoncodes
Copy link
Member

Should the .gemspec have the same version requirement as Appraisals?

@ltw
Copy link
Author

ltw commented Nov 21, 2012

What's Appraisals?

@jasoncodes
Copy link
Member

Appraisal is a tool to test a library against different dependency versions. Postmarkdown’s tests run on Rails 3.0, 3.1 and 3.2.

@ltw
Copy link
Author

ltw commented Nov 23, 2012

I must admit, I'm not sure what you're getting at here. I see no version requirement in this .gemspec for either appraisal or combustion, and I don't see any combustion dependency declaration in appraisal's .gemspec. What exactly are you looking for?

@jasoncodes
Copy link
Member

The Appraisals file in Postmarkdown's repository.

@ltw
Copy link
Author

ltw commented Nov 25, 2012

Ah ok, fixed.

@jasoncodes
Copy link
Member

Sweet. Looks good.

jasoncodes added a commit that referenced this pull request Nov 25, 2012
Add combustion development dependency.
@jasoncodes jasoncodes merged commit 57d530e into ennova:master Nov 25, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants